Commit graph

963 commits

Author SHA1 Message Date
Leonardo Hernández Hernández
4b890336e2
use xdg-shell v3 2022-06-07 00:55:41 -05:00
Leonardo Hernández Hernández
c7007b4811
chase wlroots scene-tree changes 2022-06-07 00:31:58 -05:00
Leonardo Hernández Hernández
4dfa45659a
fix compiler error with gcc complaining about parentheses
dwl.c: In function ‘unmaplayersurface’:
dwl.c:2253:9: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
 2253 |         layersurface->layer_surface->mapped = layersurface->mapped = 0;
      |         ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [<builtin>: dwl.o] Error 1

clang not affected
2022-06-05 16:57:20 -05:00
Leonardo Hernández Hernández
b91017e713
disable scene node at unmaplayersurface() 2022-06-05 15:27:40 -05:00
Leonardo Hernández Hernández
2623a96ebf
call client_set-size() if client has a resize 2022-05-27 00:19:17 -05:00
Leonardo Hernández Hernández
52e0d00942
check client_surface() returning NULL
now client_surface()->data is a pointer to the wlr_scene_tree of clients
which allows us to not call wlr_scene_node_lower_to_bottom() for every clients
2022-05-25 17:12:44 -05:00
Leonardo Hernández Hernández
7018b9b65c
correct libinput function name for drag_lock 2022-05-25 15:01:38 -05:00
Leonardo Hernández Hernández
48ec914f43
destroy layersurface's scene node in destroylayersurfacenotify() 2022-05-25 14:49:32 -05:00
Leonardo Hernández Hernández
40449fa64f
add a new function to get a client from a wlr_surface 2022-05-23 10:55:28 -05:00
Ben Jargowsky
ecbc2c61db Add configuration options for touchpads 2022-05-23 00:01:47 +02:00
Leonardo Hernández Hernández
283c043b5c
chase wlroots scene-surface refactor 2022-05-21 20:44:08 -05:00
Leonardo Hernández Hernández
88a8b784d0
Merge remote-tracking branch 'djpohly/main' into wlroots-next
chase wlroots X11 hints update
2022-05-17 15:31:31 -05:00
Leonardo Hernández Hernández
8870ba0bb8
implement urgency hints for xwayland clients 2022-05-17 14:38:18 -05:00
Leonardo Hernández Hernández
79a148224f
specify version in wlr_xdg_shell_create() 2022-05-15 17:17:58 -05:00
Leonardo Hernández Hernández
3c11ad9aa6
fix segfault when dragging chromium tabs 2022-05-14 00:29:35 -05:00
Ben Jargowsky
06d9230a96 Run focusclient when switching to monocle layout 2022-05-13 10:20:28 +02:00
Leonardo Hernández Hernández
dca68f9aa1
Merge remote-tracking branch 'djpohly/main' into wlroots-next 2022-05-10 20:08:41 -05:00
Leonardo Hernández Hernández
22bd75226b
remove trailing whitespaces 2022-05-10 11:42:40 -05:00
Leonardo Hernández Hernández
063736f898
add -v flag to the manpage
Thanks @Humm42
2022-05-10 11:39:33 -05:00
Leonardo Hernández Hernández
5d8084daa7
add flag to print version and exit 2022-05-09 16:24:36 -05:00
Ben Jargowsky
e0d310fd84 Handle 'wlr_seat_get_keyboard' possibly returning null. 2022-05-09 14:00:21 +02:00
Leonardo Hernández Hernández
3a4b7d104f
restack xwayland surface on focusclient() 2022-04-29 17:45:02 -05:00
Ben Jargowsky
d071a899f3 Run printstatus() when a monitor is removed 2022-04-25 13:50:53 -07:00
Leonardo Hernández Hernández
dc7709a00e
schedule a configure on maximize request
see maximizenotify() for more info
2022-04-16 15:51:13 -05:00
Leonardo Hernández Hernández
a48ce99e6a
use pointer math in xytonode() 2022-04-15 17:40:02 -05:00
Leonardo Hernández Hernández
4a2e761914
replace deleted EBARF() with die() 2022-04-12 23:52:05 -05:00
Leonardo Hernández Hernández
29a2b647b2
Merge remote-tracking branch 'djpohly/main' into HEAD 2022-04-08 21:12:32 -05:00
Leonardo Hernández Hernández
c00697e643
abc 2022-04-05 23:04:04 -05:00
Leonardo Hernández Hernández
af741e586b
typedefs: abc 2022-04-05 22:15:46 -05:00
Leonardo Hernández Hernández
02ac9378c4
includes: abc 2022-04-05 22:07:59 -05:00
Devin J. Pohly
720f56161e Remove vestigial monitor configuration info
The x/y fields in monitor rules are unused and were meant to be deleted.
Also removes the outdated comment in config.h.
2022-04-03 00:01:52 -05:00
Leonardo Hernández Hernández
4d3adea683
die on pipe failure 2022-03-31 15:32:30 -06:00
Raphael Robatsch
79b7e755b0
Layer shell: Prevent infinte configure/commit loop
Check the wlr_layer_surface_v1_state.committed bitmask to see if we need
to rearrange. This is also what sway does.

Without this check, every commit request (even if only the attached buffer
changed) will lead to another configure event, which will lead to another
commit, etc.

This loop results in swaybg consuming 100% CPU.

Co-authored-by: Owen Rafferty <owen@owenrafferty.com>
2022-03-31 15:27:13 -06:00
Devin J. Pohly
0ddde0c85a move sigchld() into XWayland section 2022-03-29 16:09:29 -05:00
Devin J. Pohly
e08bd12922 make sure to leave XWayland process waitable
On SIGCHLD, check to make sure the terminated process is not the
XWayland process before reaping it, allowing wlroots to waitpid() for it
successfully.

Fixes #177.
2022-03-29 15:55:06 -05:00
Leonardo Hernández Hernández
aab397c30b
new functions ecalloc() and die()
die() replaces EBARF and BARF
and allow us to add `-pedantic` to CFLAGS
2022-03-28 15:02:09 -06:00
Leonardo Hernández Hernández
7018ed9218
createpointer now takes wlr_pointer 2022-03-25 15:27:36 -06:00
Leonardo Hernández Hernández
f75e426222
createkeyboard now takes wlr_keyboard 2022-03-25 15:27:36 -06:00
Leonardo Hernández Hernández
cb4265ac8c
check m in commitlayersurfacenotify() 2022-03-24 14:19:08 -06:00
Leonardo Hernández Hernández
a95338ca43
implement input-inhibitor protocol 2022-03-24 11:41:24 -06:00
Leonardo Hernández Hernández
ae614ee512
implement idle-inhibitor protocol
This allows clients to disable idle monitoring
2022-03-24 11:35:19 -06:00
Leonardo Hernández Hernández
faaee90cbd
destroy scene_output in cleanupmon() 2022-03-23 18:22:41 -06:00
Leonardo Hernández Hernández
3e79a9a5d7
fix drag icon's surface returned by xytonode 2022-03-23 18:22:40 -06:00
Leonardo Hernández Hernández
c2899bc00b
set position of the drag icon in startdrag() 2022-03-23 18:22:40 -06:00
Leonardo Hernández Hernández
f353a0e759
Revert "clients now works as expected in drag motion"
This reverts commit 9aec6049ec.

this problem is caused because xytonode() returns the surface of the
drag icon
2022-03-23 18:22:40 -06:00
Guido Cella
281c947e5f
inline the presentation variable
This variable can be removed since with scene-graph
wlr_presentation_surface_sampled_on_output no longer needs to be called.
2022-03-23 18:22:40 -06:00
Palanix
a41d6cb00f
Fix dwl freezing when resizing 2022-03-23 18:22:40 -06:00
Quentin Rameau
b42abeac69
Add a configuration option for fullscreen locking
Some people are annoyed to have this new behaviour forced for some
application which use fake fullscreen.
2022-03-23 18:22:40 -06:00
Leonardo Hernández Hernández
d8ab893dab
clients now works as expected in drag motion 2022-03-23 18:22:40 -06:00
Guido Cella
f2be10fd43
implement drag and drop
For brevity, only a single drag icon at a time is supported.

Co-authored-by: Leonardo Hernández Hernández <leohdz172@protonmail.com>
2022-03-23 18:22:39 -06:00
Leonardo Hernández Hernández
a7f7777907
only skip frames if there are visible clients that have a resize 2022-03-23 18:22:39 -06:00
Leonardo Hernández Hernández
40db9c88ea
remove a useless resize in mapnotify()
applyrules() calls setmon() which calls resize()
2022-03-23 18:22:39 -06:00
Leonardo Hernández Hernández
feb972acd0
fix drag icon's surface returned by xytonode 2022-03-23 15:34:17 -06:00
Leonardo Hernández Hernández
bf8cc526de
set position of the drag icon in startdrag() 2022-03-23 15:30:35 -06:00
Leonardo Hernández Hernández
7a2e0eef74
Revert "clients now works as expected in drag motion"
This reverts commit 9aec6049ec.

this problem is caused because xytonode() returns the surface of the
drag icon
2022-03-23 15:29:32 -06:00
Guido Cella
3bace9ce6b inline the presentation variable
This variable can be removed since with scene-graph
wlr_presentation_surface_sampled_on_output no longer needs to be called.
2022-03-23 22:01:04 +01:00
Palanix
7d724dc7f3 Fix dwl freezing when resizing 2022-03-23 12:09:24 -06:00
Leonardo Hernández Hernández
0662bc5a69
wlr_seat_set_keyboard() now takes wlr_keyboard as parameter 2022-03-23 09:01:01 -06:00
Quentin Rameau
326eee1444
Add a configuration option for fullscreen locking
Some people are annoyed to have this new behaviour forced for some
application which use fake fullscreen.
2022-03-22 23:51:56 -06:00
Leonardo Hernández Hernández
9aec6049ec
clients now works as expected in drag motion 2022-03-22 15:02:02 -06:00
Guido Cella
330792b1fc
implement drag and drop
For brevity, only a single drag icon at a time is supported.

Co-authored-by: Leonardo Hernández Hernández <leohdz172@protonmail.com>
2022-03-22 01:10:08 -06:00
Leonardo Hernández Hernández
ee1a72211d
only skip frames if there are visible clients that have a resize 2022-03-21 21:41:38 -06:00
Leonardo Hernández Hernández
2bc01debdc
remove a useless resize in mapnotify()
applyrules() calls setmon() which calls resize()
2022-03-21 14:21:33 -06:00
Leonardo Hernández Hernández
0dea553428
destroy scene_output in cleanupmon() 2022-03-20 19:09:28 -06:00
Leonardo Hernández Hernández
a66210ebbc
Merge branch 'main' into wlroots-next 2022-03-20 16:02:18 -06:00
Leonardo Hernández Hernández
dd463b25c7
remove independents list 2022-03-20 12:32:44 -06:00
Leonardo Hernández Hernández
c8290f8c55
Merge branch 'wlroots-next' into scenegraph-wlroots-next 2022-03-18 17:21:41 -06:00
Leonardo Hernández Hernández
98f33cd01d
follow up wlroots input device events renaming 2022-03-18 17:20:31 -06:00
Leonardo Hernández Hernández
19c14b058c
remove unneeded variables 2022-03-18 11:04:34 -06:00
Leonardo Hernández Hernández
e645ea8301
attach presentation to scene 2022-03-18 10:40:40 -06:00
Leonardo Hernández Hernández
d50bb97f56
Merge branch 'main' into scenegraph 2022-03-18 01:31:28 -06:00
Leonardo Hernández Hernández
475c134144
do not allow set client size less than its min size 2022-03-18 01:27:33 -06:00
Leonardo Hernández Hernández
467123dc99
make sure to destroy wlr_scene_node of unmanaged clients 2022-03-18 01:03:33 -06:00
Leonardo Hernández Hernández
254f799fde
do not create borders for unmanaged clients 2022-03-18 01:02:50 -06:00
Leonardo Hernández Hernández
0815626d4c
pointerfocus: only use provided surface
if a client is given focus it
2022-03-18 00:59:52 -06:00
Leonardo Hernández Hernández
1b22ef1616
use xdg_shell helper
for xwayland continue using wlr_scene_subsurface_create()
2022-03-18 00:52:21 -06:00
Leonardo Hernández Hernández
f1c92b05fb
get old client by surface's node 2022-03-18 00:49:47 -06:00
Leonardo Hernández Hernández
1dfd867d9c
fix crash of Firefox when opening a popup larger than its size 2022-03-17 21:28:07 -06:00
Leonardo Hernández Hernández
294fb324d8
constraint popups to its parent client
Closes: #146
Closes: #155
2022-03-16 23:08:17 -06:00
Leonardo Hernández Hernández
79f85bde99
Merge branch 'main' into scenegraph 2022-03-16 21:54:16 -06:00
Leonardo Hernández Hernández
2768af5a9b
make sure configure and activate listeners are removed from list 2022-03-16 21:42:45 -06:00
Leonardo Hernandez Hernandez
863eedd05e
set correct position for unmanaged clients
- don't allow to move/resize with them
- don't focus unmanaged clients on buttonpress()
2022-03-16 09:27:09 -06:00
Leonardo Hernandez Hernandez
b92c0ff57f
add support for layer_shell popups 2022-03-16 09:27:09 -06:00
Leonardo Hernandez Hernandez
1087bc5db9
use wlr_scene_xdg_surface_create() for xdg_popups 2022-03-16 08:48:41 -06:00
Leonardo Hernández Hernández
88f241d1cf
Merge branch 'fix-segfault-in-fullscreennotify' 2022-03-13 21:32:55 -06:00
Leonardo Hernández Hernández
43228bd493
don't use fullscreen event in fullscreennotify() 2022-03-13 21:31:57 -06:00
Leonardo Hernández Hernández
ebff6e38a0
always call arrange() on setfullscreen()
also don't count full screen clients on tile()
2022-03-13 17:11:52 -06:00
Leonardo Hernández Hernández
2cd0b3173d
print status about floating and fullscreen 2022-03-13 15:46:32 -06:00
Leonardo Hernández Hernández
08020d61b7
more style fixes 2022-03-11 23:02:37 -06:00
Leonardo Hernández Hernández
4d26d30220
suckless style: don't use '//' for comments 2022-03-11 18:52:22 -06:00
Leonardo Hernandez Hernandez
0e5d7124de
use loop to call arrangelayer
zwlr_layer_shell_v1_layer are ordered by bottom-most first so we can
just use a loop from 3 to 0
2022-03-11 18:46:13 -06:00
Sevz
c49a42ee58
Merge pull request #196 from noocsharp/main
die on allocation failure
2022-03-11 18:40:45 -06:00
Leonardo Hernandez Hernandez
a7c4f6100a
use scene layer shell helper 2022-03-11 16:03:58 -06:00
Leonardo Hernández Hernández
3577802541
Merge branch 'wlroots-next' into scenegraph-wlroots-next 2022-03-11 16:02:00 -06:00
Leonardo Hernandez Hernandez
4465dcb6da
fix left border 'y' position
also add comment about border ordering
2022-03-11 15:11:02 -06:00
Leonardo Hernandez Hernandez
b97d9e1ce1
use wlr_scene_node_raise_to_top() 2022-03-11 15:07:57 -06:00
Leonardo Hernandez Hernandez
2b2f72d7c2
use wlr_scene_output_send_frame_done() 2022-03-11 15:05:49 -06:00
Leonardo Hernández Hernández
05a473335e
use wlr_box for previous geom 2022-03-10 14:48:14 -06:00
Leonardo Hernandez Hernandez
8cace19218
fix crash when the last monitor is disconnected 2022-03-10 14:08:57 -06:00
Leonardo Hernández Hernández
230d3432e9
wlr_virtual_keyboard_v1 now has its own wlr_keyboard
which has its own wlr_input_device

Signed-off-by: Leonardo Hernández Hernández <leohdz172@protonmail.com>
2022-03-10 10:37:18 -06:00
Leonardo Hernández Hernández
432c15fb09
Merge branch 'main' into wlroots-next 2022-03-10 10:34:43 -06:00
Sevz
ebed67596d
Merge pull request #187 from fauxmight/new-clients-printstatus
Newly launched or closed clients ALWAYS generate status update
2022-03-10 10:21:04 -06:00
Sevz
f83f1049db
Merge pull request #149 from xi/fix-grabc-unmap
reset cursor mode when grabc is unmapped
2022-03-10 10:16:49 -06:00
Leonardo Hernandez Hernandez
d1ff1e6f75
remove typedef Decoration 2022-03-08 18:17:21 -06:00
Nihal Jere
b0098d9d09 die on allocation failure 2022-02-22 23:07:49 -06:00
Devin J. Pohly
52a33a2f1e Merge branch 'scenegraph3' of github:djpohly/dwl into scenegraph3 2022-02-15 14:16:20 -06:00
Devin J. Pohly
9090106334
Merge pull request #164 from Sevz17/change-border-color
Change border color according to focus state
2022-02-15 14:16:11 -06:00
Devin J. Pohly
a15cb1e20e
Merge pull request #160 from Humm42/closepipes
-s: close unused fds
2022-02-15 14:04:25 -06:00
Devin J. Pohly
b860932cda Merge branch 'scenegraph3' of github:djpohly/dwl into scenegraph3 2022-02-15 14:03:29 -06:00
Devin J. Pohly
22a6f6661a
Merge pull request #151 from Sevz17/scenegraph3
send frame_done also to all layer surfaces
2022-02-15 14:03:04 -06:00
A Frederick Christensen
97881c88c7 Merge remote-tracking branch 'origin/output-layout-get-box-update' into chasing-wlroots 2022-02-03 23:22:19 -06:00
A Frederick Christensen
ed44bc0c90 update wlr-output-layout-get-box 2022-02-02 23:18:58 -06:00
A Frederick Christensen
3300f6c911 Upgrade for wlroots surface refactoring
See [1] for details.

[1]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3412
2022-01-18 11:33:56 -06:00
A Frederick Christensen
317175da08 Newly launched or closed clients ALWAYS generate status update
Prior to this change, if a client whose tag(s) are not currently
selected is launched or killed, no update to status was printed and
status bars being fed by printstatus() did not update newly active
or newly inactive (but unselected) tags.
2021-12-31 14:51:50 -06:00
Devin J. Pohly
f4ae4c1a0b Merge branch 'main' into scenegraph3 2021-12-22 12:43:07 -06:00
Devin J. Pohly
f85d8e79d0 Merge branch 'wlroots-next'
wlroots 0.15.0 was released
2021-12-22 12:14:36 -06:00
Devin J. Pohly
09413da6e3 Merge branch 'main' of github:djpohly/dwl 2021-12-22 12:11:29 -06:00
Devin J. Pohly
27514b9593 Merge branch 'wlroots-next' into scenegraph3 2021-12-16 11:51:15 -06:00
Devin J. Pohly
27f66c8715 explicitly create renderer and allocator
autocreate was removed
2021-12-16 11:50:11 -06:00
Leonardo Hernandez Hernandez
52dbc97ed6 wlr_xdg_surface.configure_serial has been moved into wlr_xdg_surface_state
as seen in swaywm/wlroots@0e34208
2021-12-16 11:49:57 -06:00
Devin J. Pohly
852fe819c4 Merge branch 'wlroots-next' of github:djpohly/dwl into wlroots-next 2021-12-16 11:48:43 -06:00
Raphael Robatsch
03e167dbb7 fullscreennotify: don't crash if called before map
SDL2 calls xdg_toplevel.unset_fullscreen() before the surface is
mapped. This causes a segfault in dwl because setfullscreen() expects
the surface to be mapped already.
Therefore, delay the setfullscreen call until the surface is mapped.
2021-11-13 22:19:55 -06:00
Leonardo Hernandez Hernandez
894f2a3152
change border color according to focus state 2021-10-31 15:32:49 -06:00
Leonardo Hernandez Hernandez
05ac420342
Merge branch 'wlroots-next' into HEAD 2021-10-26 21:24:35 -05:00
Humm
ebfefa84ba -s: close unused fds
dup2 doesn’t close fds, it only duplicates them.  The old ones weren’t
closed, causing problems (like dwl blocking due to the child process
never reading from the reading end, even if stdin has been closed).
2021-10-13 23:11:40 +02:00
Leonardo Hernandez Hernandez
2c9423d1b7
wlr_xdg_surface.configure_serial has been moved into wlr_xdg_surface_state
as seen in swaywm/wlroots@0e34208
2021-10-03 22:08:00 -05:00
Leonardo Hernandez Hernandez
df332de9d2
send frame_done also to all layer surfaces
this fixes an issue when bemenu don't update his surface when typing
2021-10-02 22:24:04 -05:00
ARDiDo
99fbebcae3 Remove redundant xcursor manager 2021-09-26 20:19:36 -04:00
Leonardo Hernandez Hernandez
1e1482adcb
client_pending has been renamed as pending in wlr_layer_surface_v1
as seen in swaywm/wlroots@59fa363
2021-09-24 16:12:12 -05:00
Devin J. Pohly
7de6920bd7 send frame_done to all visible surfaces 2021-09-21 14:42:36 -05:00
Devin J. Pohly
c8bf457c0f fixup: follow name change on surface_tree_create 2021-09-21 10:42:43 -05:00
Devin J. Pohly
0146a9954b use scene_output for damage-tracked rendering 2021-09-08 23:24:11 -05:00
Devin J. Pohly
be6f573b4e use scene to keep track of LayerSurfaces' layers 2021-09-08 23:24:11 -05:00
Devin J. Pohly
1b38801eef use scene-graph API for Client/LayerSurface 2021-09-08 23:24:11 -05:00
Devin J. Pohly
929d3d9569 use type enum to distinguish Client from LayerSurface 2021-09-08 23:24:11 -05:00
Devin J. Pohly
40e45a336a Merge branch 'main' into wlroots-next 2021-09-08 23:21:51 -05:00
Devin J. Pohly
0c1e621b82 simplify fullscreen expression 2021-09-08 23:21:28 -05:00
Tobias Bengfort
79dcc0d327 reset cursor mode when grabc is unmapped 2021-09-04 13:47:49 +02:00
Devin J. Pohly
55bbbc3dcb Merge branch 'main' into wlroots-next 2021-08-23 21:08:27 -05:00
Devin J. Pohly
d4e08c0762 update deprecated xkb function name 2021-08-23 18:59:31 -05:00
Palanix
3273f749ea wlr_layer_surface_v1_close has been replaced by wlr_layer_surface_v1_destroy 2021-08-21 01:53:38 +02:00
Devin J. Pohly
1183a319a0
Merge pull request #136 from guidocella/presentation-time
implement the presentation time protocol
2021-08-14 07:53:26 -04:00
Guido Cella
d175a58d73 implement the presentation time protocol
This lets applications, such as mpv with --video-sync=display-resample,
know accurately when frames are displayed and ensure smooth video
playback.
2021-08-02 16:33:38 +02:00
David Donahue
52e6bf4735 Moved printstatus() call in focusclient() to prevent printstatus being called on every frame when things like dmenu are up 2021-07-01 15:20:30 -05:00
Devin J. Pohly
f9f3f3432b Merge branch 'xdg-activation' into wlroots-next 2021-06-30 14:09:02 -05:00
Devin J. Pohly
d4ce92a7b5 Merge branch 'xdg-activation' into wlroots-next 2021-06-03 01:44:36 -05:00
Devin J. Pohly
bd2f7fbb40 exit cleanly on INT/TERM 2021-05-26 23:30:49 -05:00
Devin J. Pohly
823cefd292 handle ephemeral pageflip failures
If a transient failure occurs in wlr_output_commit, re-render until it
doesn't happen.  This could possibly be removed if we decide to
implement damage tracking in the future.
2021-05-25 02:52:33 -05:00
Devin J. Pohly
60c40c0989 print status on output create
Along with starting the -s command earlier, this will allow the initial
monitor setup to generate printstatus info.
2021-05-24 22:31:36 -05:00
Devin J. Pohly
06ca860092 factor xwayland hackiness out into client.h 2021-05-23 18:28:13 -05:00
Sevz17
9ab5e01d5b before set tiled verify if client is xdg-shell, then set tile 2021-05-23 11:44:56 -05:00
Devin J. Pohly
d8cf65c74f implement urgency hint 2021-05-22 21:21:53 -05:00
Devin J. Pohly
93a58abf29 Wait until map to set window's tiled state
Workaround for a bug in Chromium where it fails to attach a buffer to
the surface.  Fixes #119.
2021-05-22 14:24:18 -05:00
Devin J. Pohly
3f86336bad Merge branch 'main' into pipe-status 2021-04-15 13:06:06 -05:00
Devin J. Pohly
3727f4a7b3 update status info if focused client changes title
Fixes #108.
2021-04-15 13:05:05 -05:00
Devin J. Pohly
b372d4b55e pipe status info into -s command
Unlike with X window managers, the display socket in Wayland isn't set
up prior to starting the compositor.  Because of this, you can't pipe
the compositor's output directly into a program which needs access to
$WAYLAND_DISPLAY, which is a typical setup for this purpose.  Existing
scripts have been forced to create a pipe/FIFO or a temporary file as an
intermediary.

Instead, send the status info directly to stdin of the -s command, which
*does* have access to $WAYLAND_DISPLAY.

Fixes #103.
2021-04-14 11:23:23 -05:00
Devin J. Pohly
9071ce6c84 nuke CSDs, hopefully for good! 2021-04-09 12:37:49 -05:00
Devin J. Pohly
2a9404ac2a Merge branch 'main' into wlroots-next 2021-03-30 13:57:34 -05:00
Devin J. Pohly
3c83e0cfb8 don't move/resize if already moving/resizing
Fixes #102.  The "ideal" behavior might be to ignore buttons other than
the one being used for the action, but this is super-simple and still
seems reasonable.
2021-03-30 13:56:04 -05:00
Devin J. Pohly
cd3d0a102f Merge branch 'main' into wlroots-next 2021-03-25 10:09:58 -05:00
Stivvo
38ba6d2277 Fullscreen: simplifications and fixes
Merges #69.
2021-03-25 10:05:12 -05:00
Devin J. Pohly
c2b53c2d8d
Merge pull request #91 from drdonahue/wip-tag-status-interface
Interface to display tag information on status bar
2021-03-25 09:58:17 -05:00
David Donahue
ecc60878b3 changed fprintf(stdout) instances to printf(), changed function name from statusbar to printstatus 2021-03-13 11:20:33 -06:00
Devin J. Pohly
43b6e804cf Revert "remove sigchld function"
This reverts commit 1fa72b0772.
Fixes #97.
2021-03-13 10:42:42 -06:00
Devin J. Pohly
fba820d5f6 Merge branch 'main' into wlroots-next 2021-03-10 09:53:09 -06:00
Devin J. Pohly
1fa72b0772 remove sigchld function
Explicitly setting the handler for SIGCHLD to SIG_IGN tells the OS to
reap zombie processes automatically, which is what we wanted anyway.
2021-03-10 09:50:09 -06:00
David Donahue
7cee5060bc added redirect from stdout to stderr for spawned processes to prevent conflicts with the statusbar outputs 2021-03-06 12:20:56 -06:00
David Donahue
5b51bb82e2 Fixed tab formatting in 6 locations where statusbar() is called 2021-03-01 14:38:00 -06:00
David Donahue
f5e7caac00 Changed output to stdout instead of a file 2021-03-01 13:49:29 -06:00
David Donahue
593b7eec3c updated output format for better expansibility and easier parsing 2021-03-01 13:19:25 -06:00
Devin J. Pohly
c1eb2b49cd Revert "Revert "remove EGL parameter from backend_autocreate""
This reverts commit 8ed88822ca.
2021-02-16 13:13:49 -06:00
Devin J. Pohly
e8192b4fc9 Revert "Revert "fix undeclared WLR_KEY_PRESSED""
This reverts commit a11f2bbc7a.
2021-02-16 13:13:48 -06:00
Devin J. Pohly
a11f2bbc7a Revert "fix undeclared WLR_KEY_PRESSED"
This reverts commit 67896e9d8b.
2021-02-16 13:09:00 -06:00
Devin J. Pohly
8ed88822ca Revert "remove EGL parameter from backend_autocreate"
This reverts commit 0ff13cf216.
2021-02-16 13:08:58 -06:00
Devin J. Pohly
3e82fad9c4 fix style on space-indented function 2021-02-14 12:43:10 -06:00
David Donahue
a1e24075d8 Removed unused variable from statusbar 2021-02-08 18:12:24 -06:00
David Donahue
27598bd04a added statusbar update when tags are updated 2021-02-07 01:03:04 -06:00
David Donahue
3868217466 Added interface to output information about tags, the currently selected monitor, and the focused client to a file for use by a status bar 2021-02-07 00:31:01 -06:00
Devin J. Pohly
9c1943ade5 add some explanation of output reconfiguration
Hopefully this will help "future us" understand what's going on.
2021-01-18 15:51:32 -06:00
Devin J. Pohly
a9e1cd4201 remove hacky code from output-management handler
This functionality belongs in updatemons(), where it can hopefully be
written a bit more elegantly.
2021-01-18 15:38:25 -06:00
Devin J. Pohly
ab03282295 commit entire output config, or fail and rollback
The wlr-output-management protocol requires that either all of the
changes from an apply request be applied successfully, in which case a
"succeeded" event is sent, or all of the changes are reverted and a
"failed" event is sent.  As written, this could partially commit
changes, then fail.

Test the changes first (even for an "apply" event), then commit or
rollback as appropriate.
2021-01-18 15:02:15 -06:00
Devin J. Pohly
5eefb51fea use updatemons as handler for output_layout.change
This should end up firing precisely when we need to adjust our geometry,
rather than us guessing about it based on requests.
2021-01-18 14:34:05 -06:00
Devin J. Pohly
c63d4c41ab unify increment style while we're here 2021-01-18 14:14:37 -06:00
Devin J. Pohly
81d35aaccf remove unnecessary variable 2021-01-18 14:12:38 -06:00
Devin J. Pohly
a5210f7d77 cleanup on aisle createmon() 2021-01-18 14:12:00 -06:00
Devin J. Pohly
264be4ebba
Merge pull request #80 from sam-barr/dwl_upstream
Fix Initialization of NetWM Atoms
2021-01-14 20:29:17 -06:00
sam-barr
3d696dfb7d Fix Initialization of NetWM Atoms
Additionally, variables xcursor and xcursor_mgr are only used
when xwayland is defined, so I make the variables declaration
contingent on whether xwayland is being used
2021-01-11 07:47:04 -05:00
Devin J. Pohly
6267593cc2 remove now-unneeded monitor position field 2021-01-06 17:23:35 -05:00
Devin J. Pohly
e8ca8a8ac7 use output layout for dirtomon
No need to track our own order; wlroots has a reasonable default for us
already.
2021-01-06 17:19:44 -05:00
Devin J. Pohly
4bf2923f4e
Merge pull request #72 from Stivvo/output-compile-set
Define monitor's x,y at compile time
2021-01-06 16:44:31 -05:00
Devin J. Pohly
0ff13cf216 remove EGL parameter from backend_autocreate
Tracking with breaking change in swaywm/wlroots#2593.
2021-01-04 13:55:24 -05:00
Stivvo
fa782896f8 Define monitor's x,y at compile time
Replaces the outputOrder patch.

This avoids recalculating positions and allows to arrange monitors in
any order, not just from left to right.

The order in which monitors are defined in config.h still matters but
it's just the order in the list, not the actual position.
2020-12-30 17:07:48 +01:00
Devin J. Pohly
33c36be2fc Revert "Allow toggling the layout before selecting a different one"
This reverts commit 90cc3b1e2c.  Didn't
mean to merge this change.
2020-12-28 15:51:04 -05:00
Devin J. Pohly
313d1f7ecc flesh out cleanup
This is the order of *_destroy calls which resulted in the fewest
errors/leaks detected by Valgrind.  Most of the errors come from the
gbm_allocator code - will have to figure out which destroy call is still
missing.
2020-12-27 20:04:05 -05:00
Devin J. Pohly
7b1b5c75e9 fix segfault in xwayland cursor manager 2020-12-27 14:00:07 -05:00
Devin J. Pohly
7b320a195c macroize event handlers
This was a prime candidate for reducing the verbosity of some of our
code
2020-12-27 13:28:37 -05:00
Devin J. Pohly
ef76c921ed no need to cast NULL to void * 2020-12-25 01:41:09 -05:00
Devin J. Pohly
388c5580cb consolidate some of the ugliness into a separate file
Similar to Linux kernel approach, encapsulate some of the uglier
conditional compilation into inline functions in header files.

The goal is to make dwl.c more attractive to people who embrace the
suckless philosophy - simple, short, hackable, and easy to understand.
We want dwm users to feel comfortable here, not scare them off.  Plus,
if we do this right, the main dwl.c code should require only minimal
changes once XWayland is no longer a necessary evil.

According to `cloc`, this also brings dwl.c down below 2000 lines of
non-blank, non-comment code.
2020-12-25 01:39:07 -05:00
Devin J. Pohly
efe2a97bcf fix build with -DXWAYLAND 2020-12-24 22:39:45 -05:00
Devin J. Pohly
1678b05905 don't call applyexclusive just to return 2020-12-24 22:36:32 -05:00
Devin J. Pohly
57d0760635 let's not alienate the dwm folks
Fix style.
2020-12-24 22:21:00 -05:00
Devin J. Pohly
206427537a Merge updates from guidocella
Thanks so much for helping to keep the project running while life was
crazy!
2020-12-24 21:56:41 -05:00
Devin J. Pohly
cfe7815903
Merge pull request #32 from alex-courtis/24-xwayland-cursor
#24 ensure that xwayland cursor defaults to left_ptr
2020-12-24 21:37:48 -05:00
Devin J. Pohly
7803022d33 simplify ROUND macro 2020-12-24 21:37:21 -05:00
Devin J. Pohly
128c2926e1
Merge pull request #54 from Bonicgamer/swayscalebox
Sway scale_box (rounding)
2020-12-24 21:36:38 -05:00
Devin J. Pohly
c5087d413f
Merge pull request #53 from Stivvo/fullscreen
Fullscreen support
2020-12-24 21:35:57 -05:00
Devin J. Pohly
d94266df91 fix crash on non-libinput pointers (e.g. X11 backend) 2020-12-24 21:15:40 -05:00
Devin J. Pohly
62529e251d
Merge pull request #49 from guidocella/layer-shell
Layer shell
2020-12-24 20:24:14 -05:00
Devin J. Pohly
b6a3891ce6
Merge pull request #62 from Java-boi/master
Added basic tap-to-click for touchpad users
2020-12-24 18:55:06 -05:00
Stivvo
d21d5ee262 Change fullscreen policies
When a new client is spawned, fullscreen isn't disabled for all clients
in that monitor any more.

Instead, all fullscreen clients are kept fullscreen, while other clients
spawn in the background.

When fullscreen is disabled, all clients are rearranged.

This is made to make dwl more flexible allowing multiple fullscreen
clients at the same time, have floating clients on top of a fullscreen
one and let stuff happen without quitting fullscreen, like many other
WMs and DEs.
2020-12-24 21:05:34 +01:00
Stivvo
707c1710b7 quitallfullscreen() even when enabling fullscreen
Disable fullscreen on all visible clients in that monitor also before
enabling it on another client.

quitallfullscreen() is reintroduced becouse is now more useful

set c->isfullscreen later to avoid making quitallfullscreen() disable
fullscreen on the current client
2020-12-24 12:29:44 +01:00
Stivvo
86ba4c8526 Remove goto render (easier merge) 2020-12-24 00:34:33 +01:00
Guido Cella
33e8a3f1f3 update comments and remove debugging printf 2020-12-21 11:22:04 +01:00
Stivvo
5668c61616 Define monitor order with monrules[]
The order in which monitors are defined in monrules[] actually matters.

Monotors that aren't configured in monrules[], it will always be the
leftmost.
2020-12-21 11:12:44 +01:00
Guido Cella
cf7c5eae21 don't reset the cursor image
...in internal calls to restore pointer focus. Necessary for the
unclutter patch, and there's no harm in avoiding this call even in
mainline; might prevents issues in same edge cases.
2020-12-21 10:28:09 +01:00
Guido Cella
499cb2c2b6 say TODO
just wtf is XXX supposed to be? It sounds like a pornographic thing.
2020-12-20 18:19:49 +01:00
Guido Cella
5ed227384b rename drw
It's impossible to understand that this stands from drawable if you're
not familiar with dwm's code.
2020-12-20 18:19:43 +01:00
Guido Cella
b161b5d8f4 don't notify of activity
...or update selmon when we just want to restore pointer focus.
2020-12-20 16:04:13 +01:00
Guido Cella
13c7e039bb deactivate the focused client on overlay focus 2020-12-20 15:55:52 +01:00
Guido Cella
a571ea465c replace shouldfocusclients with checking old
And don't activate clients while an overlay is focused.
2020-12-20 15:46:31 +01:00
Guido Cella
39946e07f2 fix keyboard focus with overlays
Don't let internal calls to motionnotify(0) meant to update the pointer
focus from maplayersurfacenotify and destroylayersurfacenotify also
shift the keyboard focus to the surface under the cursor with
sloppyfocus.
2020-12-20 15:46:31 +01:00
Guido Cella
f80f08848b ensure that xwayland cursor defaults to left_ptr
Don't show an X cursor when closing an Xwayland window or with certain
dropdowns.

Based on https://github.com/djpohly/dwl/pull/32
2020-12-20 14:57:41 +01:00
Guido Cella
444a5f9dec enable adaptive sync
The comment in this function's declaration says the backend is free to
ignore this setting, so maybe there's no need to make it configurable?
2020-12-20 14:57:41 +01:00
Guido Cella
6b47e2bb62 use bool
Because it's 2020. Passing integers to wlroots variables and functions
with bool in their signature is silly.
2020-12-20 14:57:39 +01:00
Guido Cella
0b2f4f213d remove -Werror=declaration-after-statement
wtf is the point of this crap? It makes the code harder to follow,
increases the line count and made me fail compilation a million times.
We shouldn't blindy follow everything about suckless's style.
2020-12-19 19:52:28 +01:00
Guido Cella
ba1540c3d0 remove goto when the border is 0
Rendering 0-dimension rectangles no longer crashes wlroots.
2020-12-19 19:32:16 +01:00
Guido Cella
2eaa8c6de3 remove useless assignment
calloc already initializes ints to 0.
2020-12-19 18:56:42 +01:00
Guido Cella
ee7e8688a7 s/maprequest/mapnotify
This should be consistent with other function names instead of keeping
the X name.
2020-12-19 18:51:22 +01:00
will
aa679c4f29 Added support for natural scrolling 2020-12-19 18:37:10 +01:00
will
4f1e557d3d Added basic tap-to-click for touchpad users 2020-12-19 18:37:10 +01:00
Bonicgamer
679f6493c9 Made scalebox the way sway does it
Scaling a wlr_box without rounding can sometimes make the borders not
connected and nice. I noticed this when setting scale in monrules to 1.2

So I've went and copied what Sway did in desktop/output.c but without
having a second function and now using a random rounding macro I found
on the internet so as to not use round from math.h.
2020-12-19 18:35:25 +01:00
Guido Cella
9c2524b06a s/prev/old
Be consistent with the rest of the code and dwm
2020-12-19 18:31:26 +01:00
Guido Cella
c89de53de3 remove togglefullscreen keybinding
Distribute it as a patch like in dwm since graphical applications
usually provide their own keybinding; I guess it's only for terminals.

Note that even though these commits don't let you open multiple windows
in fullscreen and cycle between them like in dwm, with just
fullscreennotify spawning new windows or changing tag would still exit
fullscreen automatically, but you would have to toggle fullscreen twice
when switching back to the fullscreen window to enter fullscreen again,
so this is better since it avoids that.
2020-12-19 18:23:23 +01:00
Stivvo
14ce016213 Readme: achieve fullscreen + allow borderpx = 0 2020-12-19 18:06:38 +01:00
Stivvo
1e134fde97 Quit fullscreen on new x11 window
After the removal of quitfullscreen() dwl wouldn't compile widh xwayland
enabled because createnotifyx11 was still using the old function
2020-12-19 18:06:38 +01:00
Stivvo
32612c90b6 Delete quitfullscreen()
quitfullscreen() was replicating the functionalities of setfullscreen(c,
0)

Reusing setfullscreen() in quitfullscreen() leads to a 3 line function,
which is useless since quitfullscreen() is used once anyway
2020-12-19 18:06:37 +01:00
Stivvo
5a16649e79 Keep windows fullscreen after redraw
This fixes the bug that happens when changing workspace (or any time
arrange() is called) where there are fullscreen windows, which are still
fullscreen but leave the space for layer surfaces like waybar (which
should be hidden when going fullscreen)

Also as soon one fullscreen window is found hte function returns to
improve efficiency
2020-12-19 18:06:11 +01:00
Stivvo
02a09cb854 Set fullscreen simpler 2020-12-19 18:06:11 +01:00
Stivvo
cb9269df41 use m->m (fullscreen on top of layers) 2020-12-19 18:06:11 +01:00
Guido Cella
36b9831ffd fix typo 2020-12-19 18:06:11 +01:00
Stivvo
5bd9be3a75 Allow borderpx = 0 2020-12-19 18:06:11 +01:00
Stivvo
f125e1b9a4 Toggle fullscreen on all clients
mod+e allows to toggle fullscreen any client, even those who don't
support it themselves
2020-12-19 18:06:11 +01:00
Stivvo
d41cc60ec1 Handle new windows
Windows lose fullscreen state when a new window is created in the same
tag
2020-12-19 18:06:09 +01:00
Stivvo
2abfd475de isfullscreen int 2020-12-19 18:05:51 +01:00
Stivvo
af68b71094 Same fscreen func for xdg and xwayland 2020-12-19 18:05:51 +01:00
Stivvo
64113a682f Fullscreen xwayland 2020-12-19 18:05:51 +01:00
Stivvo
573535c89c Unlink fullscreen 2020-12-19 18:05:51 +01:00
Stivvo
60a732ceb8 Restore windows after fullscreen
Store position and size of windows before going fullscreen. This is more
efficient than arrange() and also works with floating windows

All the clients keep their original position because arrange() isn't
used after quitting fullscreen
2020-12-19 18:05:51 +01:00
Stivvo
de6db97401 No borders on fullscreen windows
Some code has been borrowed from the smartBorders patch
2020-12-19 18:05:51 +01:00
Stivvo
dd3920e75d Toggle fullscreen 2020-12-19 18:05:51 +01:00
Stivvo
0f04c76387 Basic fullscreen 2020-12-19 18:05:51 +01:00
Guido Cella
0f48c9552e handle the x11 configure event
This fixes the window size of old games in Wine.
2020-12-19 12:34:32 +01:00
Guido Cella
0016a209e4 implement the virtual keyboard protocol
This is used by wtype.

Also properly cleanup keyboards. Without wl_list_remove(&kb->link) dwl
crashed after using wtype 2-3 times.
2020-12-19 12:34:32 +01:00
Guido Cella
90cc3b1e2c Allow toggling the layout before selecting a different one 2020-12-19 12:34:32 +01:00
Guido Cella
41cc23e1cf Implement the idle protocol
It allows clients such as swayidle and chat applications to monitor user
idle time.
2020-12-19 12:34:32 +01:00
Guido Cella
1024928c15 deactivate focused client when spawning a new one
Because maprequest immediately calls wl_list_insert(&fstack, &c->flink),
in the following call to setmon(), the selclient() which is passed to
focusclient() as the old client is actually the newly mapped client, and
the real old one is never deactivated. You can see this by, for example,
opening Chromium's devtools, then spawning a terminal. The background of
the focused line in the devtools doesn't change from light blue to grey.

We can't just remove wl_list_insert(&fstack, &c->flink) from maprequest,
because calling wl_list_remove in focusclient() with a client that has
not been added to the list causes a segmentation fault.
Therefore we fix the focusclient call by not passing it the old client
every time, but instead using the wlroots function that gets the focused
surface and deactivate that, like in TinyWL.
This also avoids getting the selected client and passing it to
focusclient() on every call unnecessarily, and will allow removing
shouldfocusclients in a future commit by checking if old is a layer
surface instead.
2020-12-19 12:34:31 +01:00
Guido Cella
64faad7cb6 implement the wlr-data-transfer protocol
It makes wl-clipboard work properly in neovim, without having to create
a transparent surface that steals focus and causes flickering. It's also
required for clipman.
2020-12-19 12:26:31 +01:00
Guido Cella
ee5bd9a643 fix temporarily disabling a single monitor
The code in this else completely freezes my system when I run the
swayidle command to replicate xset dpms force off. No idea if it works
on multiple monitors, but for now avoid running when there's 1 monitor.

Also remove the comment with the function name in sway.
2020-12-19 12:26:14 +01:00
Richard Ipsum
67896e9d8b fix undeclared WLR_KEY_PRESSED 2020-11-23 16:58:43 +00:00
Stivvo
d9ab75721a Don't switch to another disabled monitors
Since wlr_output_enable doesn't have any effect before finishing all the
procedure, a little hack allows to make use of focusmon(), which must
know the latest in about which output is currently disabled

Also improve performance in focusmon() and cleaner code in
outputmgrapplyortest()
2020-10-31 18:29:33 +01:00
Stivvo
80a685ee51 Fix crash with no monitors left
When there's no monitors left, prevent the while in cleanupmon() to
become an infinite loop

Also switch to the left monitors instead of the right
2020-10-31 17:11:16 +01:00
Stivvo
5221a329e2 closemon() has now only 1 parameter 2020-10-31 16:25:46 +01:00
Stivvo
934ce085b6 Don't switch to disabled mons after unplug 2020-10-31 16:25:29 +01:00
Stivvo
38606a1d23 Merge branch 'handleUnplug' into output-management 2020-10-31 16:16:22 +01:00
Stivvo
9f0b16868a Back to closemon() with one parameter
With the recent changes in output-management, the extra argument in
closemon() would be needed only when unplugging the monitor, so it isn't
worth it anymore. Also now is more efficient.
2020-10-31 13:19:31 +01:00
Stivvo
9f3f15b467 Disable mon faster
Since focusmon() now never focuses disabled monitors, there's no need to
focus the disabled monitor first
2020-10-31 13:00:55 +01:00
Stivvo
25671d7905 Fix crash when disabling focused mon
m->link.next leads to errors if the monitor to disable doesn't have a
"next" (right) monitor and is currently focused. dirtmon() does more
checks.

In some previous commits m->link.next is told to be left monitor, which
is wrong

Also focusclient() explicitly checks for disabled monitors (this fixes
in case of more than one disabled monitor)
2020-10-31 12:52:22 +01:00
Stivvo
5622dbdaf3 Fix crash unplugging focused mon 2
Focus the top client on newmon, which we know for sure that it isn't
going to be unplugged or disabled and actually set that as the focused
monitor to move the focus. This is necessary to prevent crash when
disabling monitors with the output-management patch.
2020-10-31 11:17:57 +01:00
Stivvo
0a0e61e58d Merge branch 'handleUnplug' into output-management 2020-10-31 11:04:04 +01:00
Stivvo
fab42e7c41 Fix crash unplugging a focused mon
Focus newmon, which we know for sure that it isn't be unplugged or
disabled
2020-10-31 11:03:00 +01:00
Stivvo
a4d42ea798 Focus client on a new monitor before closing 2020-10-31 00:01:59 +01:00
Stivvo
62fb4c086e Block access to disabled monitor
Before this, pressing mod+comma or mod+period (focusmon function) moved
the focus to disabed monitors. Now, all disabled monitors are skipped
2020-10-30 23:49:01 +01:00
Stivvo
388ab9df2f Move disabled clients to the left
To the nearest monitor to the left of the disabled one
2020-10-30 23:34:26 +01:00
Stivvo
806ebffe7d Merge branch 'handleUnplug' into output-management 2020-10-30 23:31:46 +01:00
Stivvo
fbbc1fd656 Merge branch 'handleUnplug' of http://olidata.stivvo01.com:3000/Stivvo01/dwl into handleUnplug 2020-10-30 23:30:00 +01:00
Stivvo
d4178b9d2a Closemon(), newmon as parameter
This allows to fix output-management: move clients to the monitor on the
left of the disabled one, instead of the leftmost (which might happen to
be the disabled one)

Also using wl_list_foreach() and then brake after the first iteration is
ugly and inefficient
2020-10-30 23:22:55 +01:00
Stivvo
4deeddceff Actually move clients away from a disabled mon
When using wlr-randr every monitor's configuration is reevaluated, so it
must check which monitors are actually being disabled. The only way to
correctly do that is to compare the names.
2020-10-30 22:35:05 +01:00
Stivvo
874a4df389 Merge branch 'handleUnplug' into output-management 2020-10-30 19:56:14 +01:00
Stivvo
618972696d Fix crash when unplugging a focused monitor
Just focus a "safe" monitor before trying to to anything risky
2020-10-30 19:52:20 +01:00
Stivvo
7d67b77a96 Cleaner if statement 2020-10-30 16:21:00 +01:00
Stivvo
42aea0b17d Handle monitor enable 2020-10-25 12:37:05 +01:00
Stivvo
4c0d59c1a7 Move clients away from a disabled monitor
When a monitor is disabled with wlr_randr, all clients on that monitor
aren't lost but they are moved to the leftmost monitor with the same
method that handles monitor hot unplug
2020-10-25 11:22:58 +01:00
Stivvo
927352865c Merge branch 'handleUnplug' into output-management 2020-10-25 11:08:08 +01:00
Stivvo
ef7043e4d1 closemon()
Separate oputput movement from cleanupmon
2020-10-24 23:40:19 +02:00
Stivvo
db95024211 Merge branch 'handleUnplug' into output-management 2020-10-24 22:51:26 +02:00
Stivvo
fcc869ed84 Readme: achieve fullscreen + allow borderpx = 0 2020-10-24 16:51:22 +02:00
Stivvo
7017a0c64d fix compile error mixed declaration 2020-10-18 18:37:55 +02:00
Guido Cella
f21d3796b8 Move sgeom assignment
There is no need to repeat this. This needs to be reculalculated in my
output-management implementation too, and since I'm already calling
updatemons, this patch avoids having to repeat the assignment again.
2020-10-17 20:33:53 +02:00
Guido Cella
b30e18fa20 Implement the output management protocol
It allows clients such as wlr-randr to configure the display.
2020-10-17 20:11:31 +02:00
will
7ad14a9660 Added support for natural scrolling 2020-10-17 16:18:44 +02:00
will
598516d808 Added basic tap-to-click for touchpad users 2020-10-17 13:52:53 +02:00
Stivvo
c98686cf16 Quit fullscreen on new x11 window
After the removal of quitfullscreen() dwl wouldn't compile widh xwayland
enabled because createnotifyx11 was still using the old function
2020-10-14 17:30:10 +02:00
Stivvo
0ad8473a57 Delete quitfullscreen()
quitfullscreen() was replicating the functionalities of setfullscreen(c,
0)

Reusing setfullscreen() in quitfullscreen() leads to a 3 line function,
which is useless since quitfullscreen() is used once anyway
2020-10-14 15:46:35 +02:00
Stivvo
a2ed3d45bb Keep windows fullscreen after redraw
This fixes the bug that happens when changing workspace (or any time
arrange() is called) where there are fullscreen windows, which are still
fullscreen but leave the space for layer surfaces like waybar (which
should be hidden when going fullscreen)

Also as soon one fullscreen window is found hte function returns to
improve efficiency
2020-10-08 21:04:53 +02:00
Stivvo
172bcfd3ff Set fullscreen simpler 2020-10-08 21:04:28 +02:00
Stivvo
2b286ffeed use m->m (fullscreen on top of layers) 2020-09-16 09:20:09 +02:00
Stivvo
d8f752c9b4 Keep client tags on unplug
When unplugging a monitor, each client is moved to the same tag number
as before on the new monitor
2020-09-15 12:28:58 +02:00
Stivvo
bece225934 Handle monitor unplug
Floating widndows with "x < removed monitor's width" aren't resized
(they used to disappear in negative coordinates).

Actually delete monitors when they are unplugged, recalculate sgeom and
give a new monitor to clients that were on the removed one with setmon()

arrangefloat() funcion has been exploded to save iterations in
cleanupmon().

Also if a monitor that supports auto suspension is turned off, dwl will
count it as unplugged (it will become unreachable and all clients will
be moved to the leftmost monitor). However, if at least one monitor
isn't plugged in, dwl will still crash the same as before.

Unlike sway, when the output configuration is changed and restored,
(unplug + plug the same monitor for example) previous application
positions aren't kept. This is due to the fact that on sway every
workspace is unique among all monitors.
2020-09-15 12:28:49 +02:00
Stivvo
537ad7e3fd Restore floating win position after mon add
Compensate the coordinate changes when adding a new monitor.

Every test so far confirms that monitors are always added to the left,
on top of the list, so every floating window's x coordinate has to be
incremented by the width of the new monitor.
2020-09-12 00:21:58 +02:00
Guido Cella
0bb25a73ec extract function and comment it 2020-09-11 14:52:59 +02:00
Guido Cella
e4d58c39e0 remove braces 2020-09-11 13:15:31 +02:00
Guido Cella
fbd905155a fix multi monitors even more
When a monitor is created or removed, the geometries of the old ones
must be updated. This is also more efficient than before since we
calculate the monitor geometries only when creating and destroying
monitors. arrangelayers() is needed to recalculate m->w. arrange() is so
clients don't move to the left monitor when plugging or unplugging
monitors (clients keep the same coordinates but the field below them
changes).
2020-09-11 13:09:18 +02:00
Guido Cella
8d8d24db09 fix typo 2020-09-10 09:09:46 +02:00
Guido Cella
8f0ce672d3 simplify 2020-09-10 06:01:18 +02:00
Guido Cella
143dce094c fix multi monitors further
Fix layer surfaces without an exculsive area by using the right x and y
for the current monitor (by Stivvo).
2020-09-09 17:13:30 +02:00
Bonicgamer
4915214e47
Made scalebox the way sway does it 2020-09-08 14:53:34 -04:00
Guido Cella
62250661cf remove unneeded line
The bug was caused by usable_area's x and y not being set in
arrangelayers. For example if on a 2nd HD monitor, x should be 1920
while the first one ends at 1919. So I don't see why m->m should be
recalculated after creating the monitor.
2020-09-08 13:36:46 +02:00
Guido Cella
68412d8957 try to fix again
Calculate x and y of usable_area, not just width and heigth.
2020-09-08 12:49:05 +02:00
Guido Cella
69847872bb fix multi monitors
If you don't recalculate the monitor's geometry before arranging,
clients get arranged in the first monitor. I don't understand why this
fixes the bug since tile() uses m->w rather than m->m, nor why it needs
to be recalculated after creating the monitor but sway does it too.

Although not necessary to fix the bug I also made arrangelayer() do like
sway again and recalculate usable_area instead of reusing m->m, since
m->m seems to be incorrect until it gets recalculated shortly after in
arrange(), so I suspect that leaving usable_area = m->m will cause
issues under certain circumstances.

Someone with a multi-monitor setup or better knowledge of Wayland may be
able to figure out the cause of the bug. For now, this makes layer shell
work.
2020-09-08 10:28:29 +02:00
Guido Cella
79f3bbaf38 remove variable 2020-09-06 19:59:58 +02:00
Stivvo
d8570d5ceb Allow borderpx = 0 2020-09-06 12:20:41 +02:00
Guido Cella
52a4d3a1e5 use size_t for lengths 2020-09-05 18:29:39 +02:00
Guido Cella
9743778d09 rename variable and merge 2 lines 2020-09-05 14:15:03 +02:00
Stivvo
621d4c9173 Toggle fullscreen on all clients
mod+e allows to toggle fullscreen any client, even those who don't
support it themselves
2020-09-05 11:22:24 +02:00
Stivvo
d9cf3e064c Handle new windows
Windows lose fullscreen state when a new window is created in the same
tag
2020-09-05 11:02:13 +02:00
Stivvo
73d717a924 isfullscreen int 2020-09-05 10:40:52 +02:00
Stivvo
bd222cb75d Same fscreen func for xdg and xwayland 2020-09-05 10:40:52 +02:00
Stivvo
dd2adb38ae Fullscreen xwayland 2020-09-05 10:40:52 +02:00
Stivvo
aeae3dadbb Unlink fullscreen 2020-09-05 10:37:59 +02:00
Guido Cella
6b25e7ef27 simplify 2020-09-05 06:58:54 +02:00
Guido Cella
8ee0200877 use unsigned int for loop indexes 2020-09-04 21:36:43 +02:00
Guido Cella
ae798c694a Don't let overlays lose focus
if you open a new window while an overlay is mapped, the overlay should
stay focused
2020-09-04 21:35:48 +02:00
Guido Cella
8de18f9bb4 fix restoring pointer focus
I don't know why I thought it was working before. Maybe I should go do
something else.
2020-09-04 21:14:02 +02:00
Guido Cella
71572521e9 improve code style 2020-09-04 18:45:30 +02:00
Guido Cella
9308a90d11 remove comment
I don't know why it wasn't working before but now it does ¯\(ツ)/¯
(it wasn't caused by the just removed code either)
2020-09-04 18:04:20 +02:00
Guido Cella
8e81c90f31 remove mysterious code
Why would a surface that's not keyboard interactive get focused? Let's
remove this for now and see if issues arise.
2020-09-04 17:38:37 +02:00
Guido Cella
2d84c74657 focus the previous client in the similar code too 2020-09-04 17:38:04 +02:00
Guido Cella
068352e888 refocus old client
When a layer surface is destroyed focus should be returned to the last
client. Luckily if there are multiple overlays the previous overlay
still gets focused.
2020-09-04 17:21:48 +02:00
Stivvo
43bd806291 Restore windows after fullscreen
Store position and size of windows before going fullscreen. This is more
efficient than arrange() and also works with floating windows

All the clients keep their original position because arrange() isn't
used after quitting fullscreen
2020-09-04 17:11:26 +02:00
Stivvo
4b1ab7804b No borders on fullscreen windows
Some code has been borrowed from the smartBorders patch
2020-09-04 17:09:42 +02:00
Guido Cella
4341deae8f fix alhpabetical order 2020-09-04 17:01:34 +02:00
Guido Cella
5dc9460044 simplify focus leave condition 2020-09-04 16:42:14 +02:00
Guido Cella
35b93669f1 reuse motionnotify() 2020-09-04 15:35:04 +02:00
Stivvo
06982a56b5 Toggle fullscreen 2020-09-04 14:04:19 +02:00
Stivvo
60f0b667b1 Basic fullscreen 2020-09-04 12:44:09 +02:00
Guido Cella
d98ca07a64 enable pointer on layer surfaces 2020-09-04 07:42:51 +02:00
Guido Cella
b26ede4727 more TODOs 2020-09-03 18:59:27 +02:00
Guido Cella
4017a27b67 fix focus leave condition
needs refactoring and testing
2020-09-03 18:58:27 +02:00
Guido Cella
b4d9a8662f send pressed keys to topmost layer surface 2020-09-03 18:34:41 +02:00
Guido Cella
5d4eadeb8e remove blank line 2020-08-29 08:42:17 +02:00
Guido Cella
3203d1bafd don't handle failed calloc
be consistent with the rest of the code
2020-08-29 08:41:51 +02:00
Guido Cella
ddd3c2ad7e order variables more how like they are initialized 2020-08-29 07:42:47 +02:00
Guido Cella
2c08d0b421 Reuse render() and struct timespec *now 2020-08-28 09:00:03 +02:00
Guido Cella
03c020f058 reuse m->m 2020-08-27 06:45:26 +02:00
Guido Cella
1473d03293 remove comment
wlr_output_layout_get_box internally calls
wlr_output_effective_resolution
2020-08-27 06:04:57 +02:00
Guido Cella
c9f92bdd0e set a monitor geometry only when creating it
Lets layers with an exclusive area shrink the usable area
2020-08-27 05:22:27 +02:00
Guido Cella
b8a6d3e86a render in the same order as sway 2020-08-27 05:03:01 +02:00
Guido Cella
e13d193346 correct variable name 2020-08-26 19:52:03 +02:00
Guido Cella
ce7bc8125d rename functions too 2020-08-26 19:51:08 +02:00
Guido Cella
e69c3d7336 remove extra space 2020-08-26 19:16:13 +02:00
Guido Cella
b35182f519 render layer surfaces 2020-08-26 19:04:30 +02:00
Guido Cella
1e2dde6674 improve naming
rename Layer to LayerSurface; layer should refer to overlay, top, bottom
or background
LayerSurface variables are always called layersurface
wlr_layer_surface_v1 variables are always called wlr_layer_surface
2020-08-26 17:33:17 +02:00
Guido Cella
05df9201b3 layer shell initial attempt 2020-08-24 07:04:34 +02:00
Devin J. Pohly
44ef698d6e set up interfaces in same order as sway
This makes it easier to compare WAYLAND_DEBUG logs when troubleshooting.
2020-08-23 10:01:39 -05:00
Guido Cella
1c9a0d8822 enable gamma control 2020-08-22 18:09:38 +02:00
Devin J. Pohly
620da43933 cleanup function to match dwm 2020-08-19 00:32:57 -05:00
Devin J. Pohly
8eb6fe8e9e fix usage to match 2020-08-19 00:32:32 -05:00
Devin J. Pohly
3b1992ca91 we're not really using the log 2020-08-19 00:30:00 -05:00
Devin J. Pohly
f79746c578 this is technically barf too I guess? 2020-08-19 00:24:57 -05:00
Devin J. Pohly
f13227ebae only call updatewindowtype for x11 windows 2020-08-19 00:23:54 -05:00
Devin J. Pohly
ad9b3bc65d handle NULL return from backend_autocreate
Fixes #44.
2020-08-18 19:43:42 -05:00
Devin J. Pohly
83f60e89b0 add macro for fatal errors
dwm lets the OS do cleanup if the program errors out
2020-08-18 19:39:34 -05:00
Devin J. Pohly
d615d3836c Use SIGCHLD handler from dwm
Fixes #46.
2020-08-18 18:22:44 -05:00
Devin J. Pohly
c0b05eddb8 make this marginally less ugly 2020-08-16 11:36:38 -05:00
Devin J. Pohly
41c3f91b03 wlr_session_change_vt is NULL safe 2020-08-16 11:32:45 -05:00
Devin J. Pohly
c970d97f85 _net_wm not needed outside xwayland 2020-08-16 01:14:54 -05:00
Devin J. Pohly
108ade0bbc
Merge pull request #37 from alex-courtis/31-independents-mouse-focus
31 independents mouse focus
2020-08-16 00:57:18 -05:00
Guido Cella
c0608aa017 Declare commitnotify 2020-08-15 16:47:22 +02:00
Alexander Courtis
4788baee8d Merge branch 'master' into 31-independents-mouse-focus 2020-08-11 11:42:02 +10:00
Alexander Courtis
2616812a7a #24 ensure that xwayland cursor defaults to left_ptr 2020-08-11 11:29:32 +10:00
Alexander Courtis
e7318f7623 Merge branch 'master' into 24-xwayland-cursor 2020-08-11 11:23:58 +10:00
Devin J. Pohly
e3e9504fcd make XWayland support optional 2020-08-10 12:50:56 -05:00
Alexander Courtis
5b464edf91 #31 independents retain focus while mouse is over them 2020-08-09 11:56:34 +10:00
Alexander Courtis
9551568252 #31 independents retain focus while mouse is over them 2020-08-09 11:34:19 +10:00
Alexander Courtis
9d138ac95a #31 independents retain focus while mouse is over them 2020-08-06 15:41:04 +10:00
Alexander Courtis
c08ea88c1f #31 independents retain focus while mouse is over them 2020-08-06 15:32:55 +10:00
Alexander Courtis
f593820ede #24 ensure that xwayland cursor defaults to left_ptr 2020-08-04 11:53:23 +10:00
Devin J. Pohly
5a2d87fa6c add monocle layout 2020-08-03 12:44:47 -05:00
Devin J. Pohly
27bbf9c14f condense getatom and add note about error return 2020-08-03 12:22:02 -05:00
Devin J. Pohly
c12261d3a9 Merge branch 'master' of github:djpohly/dwl into master 2020-08-03 12:14:36 -05:00
Devin J. Pohly
8c95418334
Merge pull request #25 from geistesk/error-maybe-uninitialized
getatom: fix potential uninitialized atom variable
2020-08-03 12:14:27 -05:00
Devin J. Pohly
d89cf6b720 add some more hands-off protocols 2020-08-03 11:20:12 -05:00
Devin J. Pohly
0ac2f6616a fix an editing mistake 2020-08-02 18:49:23 -05:00
Devin J. Pohly
59cd8dec94 focusclient checks whether oldsel == sel
No need to do it outside the call.
2020-08-02 18:46:34 -05:00
Devin J. Pohly
ef7a37649c refactor focusclient 2020-08-02 18:43:29 -05:00
Devin J. Pohly
7856cdc1bf abc 2020-08-02 18:40:33 -05:00
Devin J. Pohly
da5deab083 convert lastfocused() to focustop(m) 2020-08-02 18:39:48 -05:00
Devin J. Pohly
8a584d406d pass previous focus to focusclient 2020-08-02 18:33:42 -05:00
Devin J. Pohly
e7e01e06f6 remove surface from focusclient function
Honestly not sure why a specific surface is focused rather than the
client figuring that out.  Seems to work in a quick test, but we can
remember this commit if something breaks for, I dunno, mouse people.
2020-08-02 18:26:58 -05:00
Devin J. Pohly
17e525cc6c C99 doesn't support anonymous unions
I'm cool with ->surface.xdg instead of ->xdg_surface though.
2020-08-02 09:16:07 -05:00
Devin J. Pohly
62339e7ab0 make setmon a bit more straightforward 2020-08-02 00:35:26 -05:00
Devin J. Pohly
e41ed53384 remove unneeded variable 2020-08-01 09:45:33 -05:00
Devin J. Pohly
2dbe5c6063 simplify pointerfocus
Similar to focusclient
2020-07-31 14:00:00 -05:00
Devin J. Pohly
90d80c0de9 simplify focusclient
This arranges the function into some logical tasks: deactivate the old
client, update wlroots' keyboard focus, update our data structures, and
activate the new client.  The last two only need to be done when
focusing something new, so an early return saves some horizontal space.
2020-07-31 13:53:33 -05:00
Devin J. Pohly
0a59f47c18 remove now-unused variables in focusclient 2020-07-31 13:24:10 -05:00
Devin J. Pohly
50aa44c59b add tag bitset check from dwm 2020-07-31 09:57:59 -05:00
Alvar Penning
744f20790c getatom: fix potential uninitialized atom variable
The getatom function returns the atom variable, which is only
initialized in case of a success. This results in a maybe-uninitialized
warning/error. After this commit, now a zero value is returned in case
of error.
2020-07-31 12:53:46 +02:00
Devin J. Pohly
4e57dbd922 attach_render and commit are all that's needed
attach_render tells the output that a "new" buffer has been prepared
(even if we haven't changed it).  We need to call that and then commit
it to keep the render loop going.

Software cursors will freeze momentarily during layout updates, but I
suspect that this is not as easily fixed as it sounds.  You can force
software cursors by running:

    WLR_NO_HARDWARE_CURSORS=1 ./dwl
2020-07-30 22:52:53 -05:00
Devin J. Pohly
21437b62af style fixes 2020-07-30 21:55:49 -05:00
Alexander Courtis
d6a18d69c0 do not render frames when any surface has uncommitted resizes 2020-07-30 21:52:09 -05:00
Alexander Courtis
7499044a2b tidy activate notify resource 2020-07-29 15:05:24 +10:00
Devin J. Pohly
d5fdd999ac make border color selection concise 2020-07-26 19:27:49 -04:00
Michael Cardell Widerkrantz
2fb3701c6e Add support to change focused window's border color 2020-07-26 23:10:42 +02:00
Devin J. Pohly
e2887f2cfd remove client.isx11 in favor of client.type 2020-07-25 12:03:08 -04:00
Devin J. Pohly
0e21cce803 ok, treat it like an enum 2020-07-25 11:57:47 -04:00
Devin J. Pohly
3e29ef1c7e do managed/unmanaged check in map and unmap 2020-07-25 11:55:18 -04:00
Devin J. Pohly
f2d025d4e9 do managed check in activatex11 2020-07-25 11:48:47 -04:00
Devin J. Pohly
e5e170e420 add client.type field
Current options are XDGShell, X11Managed, and X11Unmanaged.
2020-07-25 11:46:12 -04:00
Devin J. Pohly
39f3b87f3a rename activate to activatex11 for consistency 2020-07-25 11:46:12 -04:00
Devin J. Pohly
8b7cc8ada6 clarify createnotifyx11 function 2020-07-25 11:29:36 -04:00
Alexander Courtis
c4cf78aadb xwayland: unmanaged (dropdown menu) support 2020-07-25 11:29:02 -04:00
Devin J. Pohly
4bc7f2d8e4 remove n counter from zoom(), add comments 2020-07-24 17:35:19 -04:00
Guido Cella
7b608da8c5 Add zoom 2020-07-24 17:30:45 +02:00
Devin J. Pohly
53798dfbff fix WLR_SURFACE macro 2020-07-23 19:32:10 -04:00
Devin J. Pohly
5d66ea8a99 don't double-add new monitor to mons
this was a copy/paste error
2020-07-23 18:14:33 -04:00
Devin J. Pohly
d42d8bda42 add cleanup listener for keyboards 2020-07-23 18:13:42 -04:00
Devin J. Pohly
89e9a4be33 add monitor destroy listener 2020-07-23 18:03:13 -04:00
Devin J. Pohly
5ca1e22fef reorder teardowns 2020-07-23 17:36:20 -04:00
Devin J. Pohly
8b13e42d3f fix more unfreed memory 2020-07-23 17:34:50 -04:00
Devin J. Pohly
bc65c1a570 output_layout_manager not auto-destroyed 2020-07-23 17:20:23 -04:00
Devin J. Pohly
91000b5e76 xcursor_manager is not automatically destroyed 2020-07-23 17:16:02 -04:00
Guido Cella
ea73221b45 Add killclient 2020-07-23 20:30:25 +02:00
Devin J. Pohly
4a4a261111 let xdg be the plain "createnotify"
use x11 suffix for other function to match isx11, also shorter
2020-07-22 20:54:39 -04:00
Devin J. Pohly
ce2c9e6660 xwayland is the exceptional case, let xdg be 0 2020-07-21 23:25:16 -04:00
Devin J. Pohly
a10357fae0 condense appid/title logic 2020-07-21 18:47:30 -04:00
Devin J. Pohly
a21c9378ee fix segfault on xwayland "appid" 2020-07-21 18:43:26 -04:00
Alexander Courtis
57fef50310
xwayland: add server and basic window functionality (#10)
* xwayland: add server and basic window functionality

* xwayland: add server and basic window functionality

* xwayland: add server and basic window functionality

* xwayland: add server and basic window functionality
2020-07-21 18:35:46 -04:00
Lauri Gustafsson
91b18d4d4d
Add repeat delay and repeat rate to config.h (#13) 2020-07-02 15:41:12 -05:00
Devin J. Pohly
728e0e5d71 clear correct focus on keyboard leave 2020-06-15 09:22:43 -05:00
Shugyousha
63f09d1f23
Don't pass NULL surfaces to wlr focus functions (#8)
Turns out that this will hit asserts that will abort dwl.
2020-06-14 04:05:21 -05:00
Devin J. Pohly
14063d58bb Handle missing XDG_RUNTIME_DIR explicitly
Also update the documentation to indicate that this is a Wayland thing
and not dwl-specific.
2020-06-07 11:43:48 -05:00
Devin J. Pohly
f19d00b94a move perrors earlier
Should come right after the erroring call so nothing else has a chance
to overwrite errno
2020-06-07 11:42:43 -05:00
Martin Tournoij
da5b4d965d
Add startup errors, mention XDG_RUNTIME_DIR in README
It was just exiting with code 1 for me. The problem turned out to be
that you *need* to set XDG_RUNTIME_DIR or it won't work (I think e.g.
systemd does that for you, but on Void it's not set by default), so
mention that in the README.
2020-06-07 14:51:02 +08:00
Devin J. Pohly
8c0afa7c73 send xdg_decoration configure right after create
Thanks to @cedws for pointing this out!
2020-06-07 01:12:02 -05:00
Devin J. Pohly
2598100d53 Implement xdg-decoration protocol
Applications like alacritty which use this newer protocol will no longer
attempt to draw their own decoration.
2020-06-04 23:37:31 -05:00
Devin J. Pohly
5991cec0ff Write something more intuitive for focusclient() 2020-06-03 19:45:40 -05:00
Devin J. Pohly
78187f5e65 document -qvd options 2020-06-03 15:05:12 -05:00
Devin J. Pohly
67299a18a5 make sure freed listeners are removed from list 2020-05-10 01:04:31 -05:00
Devin J. Pohly
c6833cf93e add output manager protocol 2020-05-09 23:01:30 -05:00
Devin J. Pohly
59d16e491a add screencopy support
While we're taking low-hanging fruit here...
2020-05-09 22:48:19 -05:00
Devin J. Pohly
0bd4eb8ff3 add primary selection support too! 2020-05-09 22:45:22 -05:00
Devin J. Pohly
0b0dd6b63c handle request set selection
Ported from wlroots commit fa5d709
2020-05-09 22:30:20 -05:00
Devin J. Pohly
94bb68afe1 use wlr_xdg_surface.set_tiled correctly
Closes #2.  I'm guessing from sway that the idea of setting maximized
state so that windows cooperate is superseded by using set_tiled.
2020-05-09 14:50:31 -05:00
Devin J. Pohly
cad233b605 initialize global listeners statically 2020-05-09 10:10:02 -05:00
Devin J. Pohly
5817c917b6 abc 2020-05-03 13:18:53 -05:00
Devin J. Pohly
323092d3ce remove vestigial listeners 2020-05-03 13:18:10 -05:00
Devin J. Pohly
7212da059c no need for a line split here 2020-05-03 12:41:15 -05:00
Devin J. Pohly
1a30d9908d no conditional needed for output modes
If the output backend doesn't support modes, get_preferred_mode will
return NULL, and set_mode will accept NULL.
2020-05-03 11:45:47 -05:00
Devin J. Pohly
b19afa10f3 use strstr for monrules 2020-05-03 11:39:48 -05:00
Devin J. Pohly
7afe152c47 add reminder comment 2020-05-03 11:38:34 -05:00