Leonardo Hernández Hernández
a71b368483
Revert "remove typedef Decoration"
...
This reverts commit d1ff1e6f75
2023-12-18 12:56:19 -06:00
Leonardo Hernández Hernández
7afdc191fe
style fixes
2023-12-17 21:42:50 +00:00
David Donahue
023efce6eb
use wlr_keyboard_group to manage all keyboards
2023-12-17 21:41:39 +00:00
Leonardo Hernández Hernández
fa660fb61e
check toplevel resources
...
it's just a aesthetic change
2023-12-12 22:21:32 -06:00
Dima Krasner
9a84789ff1
restore and respect rootcolor
2023-12-11 00:30:17 -06:00
Leonardo Hernández Hernández
49bfe92703
merge X11Managed and X11Unmanaged into X11
...
now that client_is_unmanaged() checks the wlr struct we don't need to keep
track of it ourselves
2023-12-10 23:46:49 -06:00
Leonardo Hernández Hernández
9c5bdcfbe8
do not blindly try to send motion events when pointer button is pressed
...
we don't have to do this if the surface is the same
2023-12-10 23:27:59 -06:00
Leonardo Hernández Hernández
1884a07646
sort LISTEN calls in createnotify{,x11}
2023-12-07 22:40:59 -06:00
Leonardo Hernández Hernández
79c51a4584
use the same style for urgent() and sethints()
2023-12-07 22:37:35 -06:00
Leonardo Hernández Hernández
f5d839844d
remove an unneeded cast in createpointer()
2023-12-07 22:37:00 -06:00
Leonardo Hernández Hernández
e03896b4d6
avoid duplication of lines
...
the output state is copied when creating a output configuration head
2023-12-07 22:18:49 -06:00
Leonardo Hernández Hernández
e7e84b1083
add explanation about why we try to re-apply the gamma LUT on output changes
2023-12-07 22:17:48 -06:00
Leonardo Hernández Hernández
9694477b2f
relax a bit the line length limit
2023-12-07 22:16:13 -06:00
Leonardo Hernández Hernández
6a15167754
add a blank line to improve readability
2023-12-07 22:15:42 -06:00
Leonardo Hernández Hernández
e5e2d1c28f
use (struct wlr_box){0} to empty the Monitor areas
2023-12-07 22:04:24 -06:00
Leonardo Hernández Hernández
bdbfb45d66
copy layout symbol when matching a MonitorRule
2023-12-07 21:51:24 -06:00
Leonardo Hernández Hernández
50ea84c5f6
remove extra blank line
2023-12-07 21:49:26 -06:00
Leonardo Hernández Hernández
472a31b5a4
LayerSurface::link -> LayerSurface.link
2023-12-07 21:48:56 -06:00
Leonardo Hernández Hernández
a760757b82
set the correct border color when mapping a client
2023-12-07 21:44:53 -06:00
Leonardo Hernández Hernández
80c9ad12ba
reduce calls to client_get_geometry
2023-12-07 21:43:48 -06:00
Leonardo Hernández Hernández
393078d80c
store the layersurface pointer in l->popups->node.data as well
2023-12-07 14:19:09 -06:00
Leonardo Hernández Hernández
28ec843aee
make sure popups of a layer surface are in the correct layer
...
previously it worked because we checked in every commit the layer
in a353eee2cab100b446b8
2023-12-07 14:19:02 -06:00
Leonardo Hernández Hernández
2b3504e439
sort #includes
2023-12-01 21:35:50 -06:00
Leonardo Hernández Hernández
5f7d396996
don't return early if the first output commit fails
2023-11-30 22:39:03 -06:00
Leonardo Hernández Hernández
901d2e2d9d
check failure of wlr_output_init_render
2023-11-30 22:38:52 -06:00
Leonardo Hernández Hernández
00e867d536
use detached output state in createmon()
...
see previous commit for motivation
2023-11-30 22:38:39 -06:00
Leonardo Hernández Hernández
2e29189b92
use a detached output state in outputmgrapplyortest()
...
wlr_output.pending might be removed in wlroots 0.18
2023-11-30 22:38:11 -06:00
Leonardo Hernández Hernández
2e4fdc1664
use l instead of layersurface
...
`layer_surface` instead of `wlr_layer_surface`
and `scene_layer` whenever a wlr_scene_tree is related to layer surfaces
2023-11-25 19:18:19 -06:00
Leonardo Hernández Hernández
b100b446b8
return early if a layersurface didn't commit something
2023-11-25 19:17:32 -06:00
Leonardo Hernández Hernández
9cb1ece6cc
do not check if a layer surface has monitor on commit
...
We do not allow creating them w/o monitor and they are destroyed when
destroying their monitor
2023-11-25 19:17:32 -06:00
Leonardo Hernández Hernández
01a237bd5c
send wl_surface.enter before initial commit
...
It's not necessary but it'll help clients to render a perfect first frame
2023-11-25 19:17:32 -06:00
Leonardo Hernández Hernández
a5e068b20a
destroy the layer-suface's scene tree for popups
2023-11-25 19:16:33 -06:00
Leonardo Hernández Hernández
39f4ee564b
use wlr_box_equal() instead of memcmp
2023-11-25 19:08:56 -06:00
Leonardo Hernández Hernández
a353eee2ca
simplify settings popups scene tree parent
2023-11-25 19:06:17 -06:00
Leonardo Hernández Hernández
66ec028b00
simplify check for wlr_layer_surface.output
2023-11-25 19:05:27 -06:00
Leonardo Hernández Hernández
1f10e69b4c
use sizeof(*pointer) instead of sizeof(struct)
2023-11-25 19:04:57 -06:00
Leonardo Hernández Hernández
2783e82bf8
make sure to unlink Monitor.request_state listener
2023-11-25 18:53:18 -06:00
Leonardo Hernández Hernández
7ac76219df
Merge branch 'wlroots-next'
2023-11-25 00:04:19 -06:00
Leonardo Hernández Hernández
6838f909bd
try to apply gamma LUT in updatemons
...
this in the case the output was re-enabled
2023-11-21 20:41:36 -06:00
Leonardo Hernández Hernández
d2dd2f4986
ignore wl_surface.commit for xwayland clients
...
This is no longer needed
2023-11-21 20:16:26 -06:00
Leonardo Hernández Hernández
a0e79d8145
Do not send repeated xdg_toplevel.configure_bounds
...
Fixes: 32e66f4582
2023-11-21 20:15:46 -06:00
Leonardo Hernández Hernández
32e66f4582
resize clients on commit
...
Fixes: https://github.com/djpohly/dwl/issues/515
This reverts commit 4567979b16
2023-11-21 20:15:00 -06:00
link2xt
b4da97446a
createkeyboard: do not segfault if xkb_keymap_new_from_names returns NULL
...
Passing NULL to wlr_keyboard_set_keymap results in a segfault.
Example:
Thread 1 "dwl" received signal SIGSEGV, Segmentation fault.
0x00007ffff7e49b64 in xkb_keymap_ref () from /usr/lib/libxkbcommon.so.0
(gdb) bt
#0 0x00007ffff7e49b64 in xkb_keymap_ref () at /usr/lib/libxkbcommon.so.0
#1 0x00007ffff7f06389 in wlr_keyboard_set_keymap () at /usr/lib/libwlroots.so.11
#2 0x000055555555bc54 in createkeyboard ()
#3 0x000055555555c283 in inputdevice ()
#4 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0
#5 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0
#6 0x00007ffff7edb52c in () at /usr/lib/libwlroots.so.11
#7 0x00007ffff7ee44b6 in () at /usr/lib/libwlroots.so.11
#8 0x000055555555fe66 in main ()
2023-11-19 01:14:35 -06:00
Leonardo Hernández Hernández
2751a6195d
do not try to enable adaptive sync
2023-11-18 11:20:56 -06:00
Leonardo Hernández Hernández
fcf324be6c
fix the position of the cursor image after turning all the monitors on
2023-11-17 19:03:23 -06:00
Leonardo Hernández Hernández
b8e933b9a9
remove unused #include
2023-11-17 11:03:33 -06:00
Leonardo Hernández Hernández
1044a21555
do not check if session is non-NULL
...
wlr_session_change_vt() is a no-op if session == NULL
2023-11-17 11:03:33 -06:00
Leonardo Hernández Hernández
6bcd5d8d87
do not explicitly destroy some wlroots interfaces
...
they are destroyed when the wayland display is destroyed
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández
e95f14541a
fix docs
...
copied from tinywl
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández
bca1b779aa
fix destroynotify() docs
...
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4421
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández
4f4c540bb9
prevent a use-after-free at exit
2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández
8e3f5364d3
do not compute layout box twice
2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández
2212363225
make sure fullscreen clients have the right size
2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández
6f8a3f9374
fix screen artifacts when setting gamma
...
the artifacts were caused because we tried to set the gamma right after
receiving the event, this resulted in two pending page-flips, which
not always play well together.
This also seems to fix a screen freeze when turning on a monitor that has
gamma.
Additionally the current method won't work once [0] is merged
[0]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4423
2023-11-17 11:01:30 -06:00
Leonardo Hernández Hernández
e1f3983bf8
use wlr_scene_subsurface_tree_set_clip
...
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4131
Closes: https://github.com/djpohly/dwl/issues/411
2023-11-14 19:44:43 -06:00
Leonardo Hernández Hernández
31bf1cbaf6
Revert "respect size hints"
...
This reverts commit 72e0a560d9
2023-11-14 19:44:28 -06:00
Leonardo Hernández Hernández
a4a83e95e6
use newer cursor naming spec
...
References: https://www.freedesktop.org/wiki/Specifications/cursor-spec/
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4416
2023-11-01 12:28:19 -06:00
Leonardo Hernández Hernández
e45ded7eea
ignore maximize events for clients using xdg-shell v5 and newer
2023-11-01 12:16:02 -06:00
Leonardo Hernández Hernández
892a4d3ec7
Merge remote-tracking branch 'upstream/main' into wlroots-next
2023-10-13 17:10:25 -06:00
Ben Collerson
8c79f8dc15
check client is mapped before setting border color
...
For some reason brave configured for as a wayland client triggers this code on startup and segfaults.
Checking if the client is mapped fixes this, like with the previous fix for urgent border colour.
References: 887fde65a372a7d78a1a
2023-10-10 10:16:11 -06:00
Leonardo Hernández Hernández
8781f4dbf5
Merge remote-tracking branch 'upstream/main' into wlroots-next
2023-10-09 22:37:36 -06:00
Leonardo Hernández Hernández
df131cdb78
use <xcb/xcb.h> instead of <X11/Xlib.h>
2023-10-09 22:33:37 -06:00
Leonardo Hernández Hernández
887fde65a3
only set border color for urgent *and* mapped X11 clients
...
this fixes a segfault when the client emits .set_hints but it's not mapped
Fixes: 72a7d78a1a
2023-10-09 22:32:15 -06:00
Leonardo Hernández Hernández
b299e01e44
Merge remote-tracking branch 'upstream/main' into wlroots-next
2023-10-09 11:45:51 -06:00
Leonardo Hernández Hernández
6d9a915fb6
Revert "just add define"
...
I'm going to make some changes in the config file anyway
This reverts commit e5367753bb
2023-10-09 11:12:24 -06:00
Leonardo Hernández Hernández
935b852dc5
add [-d] flag to enable debug logging
2023-10-09 11:11:33 -06:00
Leonardo Hernández Hernández
a18c528300
simplify setting the border color of clients
2023-10-09 11:05:41 -06:00
Leonardo Hernández Hernández
72a7d78a1a
make the borders red borders for urgent clients
...
iirc this is the same behavior of dwm
2023-10-09 11:04:03 -06:00
Forrest Bushstone
f695674361
Check if c is fullscreen before reparenting it to LyrFloating
...
Closes: https://github.com/djpohly/dwl/issues/487
2023-09-29 18:01:31 -06:00
Forrest Bushstone
aec21eca1f
make sure that fullscreen clients are on the correct screen when isfloating is true
...
Bug: https://github.com/djpohly/dwl/issues/487
2023-09-29 18:00:32 -06:00
Leonardo Hernández Hernández
1333f8cc6e
Merge remote-tracking branch 'upstream/main' into wlroots-next
2023-09-24 11:44:29 -06:00
Leonardo Hernández Hernández
960c32a7d8
call setfloating in setmon
...
since in the previous commit we may not applying floating in clients
this is to make sure we do
2023-09-06 22:23:37 -06:00
Leonardo Hernández Hernández
aea8dd6ae1
return early if the client doesn't have monitor in setfloating
...
there is still a bug, but for now this prevents a segfault
Bug: https://github.com/djpohly/dwl/issues/472
2023-09-06 22:22:21 -06:00
Ben Collerson
e5367753bb
just add define
2023-08-22 22:20:39 -06:00
Ben Collerson
9be85c1117
tagcount should have been a #define
2023-08-22 22:20:39 -06:00
Leonardo Hernández Hernández
4b8c1bf31e
return nothing in xytonode()
...
we do not use the node
2023-08-22 14:48:29 -06:00
Devin J. Pohly
d7569870b6
Style: use early-return to clarify code
...
Use an early return to avoid indenting the main logic instead of
wrapping the tail of a function in an if statement.
No functional change, except for a handful of places where printstatus()
was being called spuriously (tag, toggletag, toggleview).
ΔSLOC: 0
2023-08-22 01:44:31 -06:00
Devin J. Pohly
4eb54b55f3
No need to send surface.leave/enter events
...
The scene graph implementation sends these for us, and it does so more
accurately than our overly-simplified approach. Layer shell surfaces
don't appear to receive these events at all, according to my
WAYLAND_DEBUG experiments with bemenu and dtao.
ΔSLOC: -4
2023-08-22 01:44:31 -06:00
Leonardo Hernández Hernández
4567979b16
don't resize clients on commit
...
It creates an infinite commit-resize loop when scale != 1
2023-08-18 21:37:22 -06:00
Leonardo Hernández Hernández
78cf88670f
add support for xdg-shell v6
2023-07-31 18:19:41 -06:00
Leonardo Hernández Hernández
ce997c4a21
update to xdg-shell v5
2023-07-23 21:15:06 -06:00
Leonardo Hernández Hernández
0e5405610e
add support for cursor-shape-v1
...
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4106
2023-07-23 19:56:55 -06:00
Leonardo Hernández Hernández
0bb1a1cc5c
increase wl_compositor version
...
Now scene will handle sending the preferred buffer scale
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4269
2023-07-15 10:11:47 -06:00
Leonardo Hernández Hernández
aecff8cb26
Merge branch 'main' into wlroots-next
2023-07-13 22:36:48 -06:00
Leonardo Hernández Hernández
ca4a97b933
do not use wl_event_loop for signal handling
...
ΔSLOC: -4
Fixes: https://github.com/djpohly/dwl/issues/456
Fixes: https://github.com/djpohly/dwl/issues/459
2023-07-13 22:32:48 -06:00
Devin J. Pohly
76ba2cdab0
Remove now-unneeded call to motionnotify
...
This appears to have been here for the side effect of updating the drag
icon's position.
2023-07-13 22:17:03 -06:00
Devin J. Pohly
4b15bbeb33
Remove unused icon variable
2023-07-13 22:17:03 -06:00
Devin J. Pohly
831fc36bc9
Make drag_icon a persistent scene node
...
If there is no current drag icon, this node will be empty, but we now
have `drag_icon != NULL` as an invariant. This allows us to eliminate a
conditional, since there's no harm in moving an empty node's coordinates
around with the pointer.
ΔSLOC: -1
2023-07-13 22:17:03 -06:00
Devin J. Pohly
1841527871
properly destroy scene
...
ΔSLOC: +1
2023-07-13 17:44:21 -06:00
Leonardo Hernández Hernández
ff7c0e9508
chase wlroots!4220
...
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4220
2023-07-10 11:23:19 -06:00
Devin J. Pohly
33bcd2e4ca
Line saver: LISTEN_STATIC macro
...
This parallels the LISTEN macro for statically allocated listeners, and
it allows us to remove almost all of the global wl_listener
declarations.
This also fixes a bug with the axisnotify listener, which was declared
with a compound literal. At block scope, these have automatic storage
duration [1], so the listener was no longer valid after setup()
returned. (The option to declare it static explicitly was standardized
in C23, if that ever gains suckless traction.)
ΔSLOC: -27
[1]: https://en.cppreference.com/w/c/language/compound_literal#Explanation
2023-07-08 16:56:09 -06:00
Devin J. Pohly
fbd84aca4a
Unify signal handling under wl_event_loop
...
Merge our signal handlers into a single function and let Wayland deal
with all the struct sigaction stuff.
ΔSLOC: -3
2023-07-03 22:28:27 -06:00
Devin J. Pohly
a01e402c5d
Line saver: follow "local = wlr->data = obj" pattern
...
There were still a couple of places where we could use this handy
multiple assignment to save a line.
ΔSLOC = -3
2023-07-03 21:21:43 -06:00
Leonardo Hernández Hernández
9dd3f230c0
Merge remote-tracking branch 'upstream/main' into wlroots-next
2023-06-29 13:11:55 -06:00
Devin J. Pohly
eda0613cc4
Separate drag icon from layers array and Lyr enum
...
If we treat the drag icon as distinct from other layers (it doesn't have
contents that are interactive, focusable, etc.), then we can iterate
over layers meaningfully with a simple for loop.
ΔSLOC: -8
2023-06-25 17:44:00 -05:00
Leonardo Hernández Hernández
733114f0ca
schedule a frame after commmiting gamma
...
not doing it, may freeze the output or do not actually change the gamma until
creating a client
2023-06-24 10:09:49 -06:00
Leonardo Hernández Hernández
fdb66ccfa3
use detached output states to set gamma
2023-06-23 13:42:44 -06:00
Leonardo Hernández Hernández
6095ff84d2
Revert "use wlr_scene_output_build_state() to set gamma"
...
This reverts commit 65f68e7643
2023-06-23 13:30:43 -06:00
Devin J. Pohly
68a17f962e
Don't bother with ignoring SIGCHLD
...
It added complexity, especially with the differences in behavior between
handled and ignored signals across an exec().
2023-06-16 00:24:17 -06:00
Devin J. Pohly
9c592da01f
Reset ignored signal handler in spawn() as well
2023-06-16 00:24:17 -06:00
