From c4a9993ac2ac55dae986c561574ef994062eda44 Mon Sep 17 00:00:00 2001 From: Mingwei Samuel Date: Fri, 13 Oct 2023 09:54:59 -0700 Subject: [PATCH] Remove tests on archived matches Also adds `--no-fail-fast` to tests --- .github/workflows/ci.yml | 2 +- riven/tests/tests_americas.rs | 4 ---- riven/tests/tests_asia_jp.rs | 22 ---------------------- test.bash | 2 +- 4 files changed, 2 insertions(+), 28 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 51b3661..186f392 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -84,7 +84,7 @@ jobs: uses: actions-rs/cargo@v1 with: command: test - args: --features nightly,deny-unknown + args: --no-fail-fast --features nightly,deny-unknown env: RUST_BACKTRACE: 1 RUSTLOG: riven=trace diff --git a/riven/tests/tests_americas.rs b/riven/tests/tests_americas.rs index 6992526..1c8dae2 100644 --- a/riven/tests/tests_americas.rs +++ b/riven/tests/tests_americas.rs @@ -13,10 +13,6 @@ use riven::consts::*; const ROUTE: RegionalRoute = RegionalRoute::AMERICAS; static MATCHES: &[&str] = &[ - // "NA1_3923487226", // Archived 2023-08-17 - "NA1_4049206905", - "NA1_4052515784", - "NA1_4062578191", "NA1_4097036960", // New games with `match-v5.ParticipantDto.challenges` field. "NA1_4209556127", diff --git a/riven/tests/tests_asia_jp.rs b/riven/tests/tests_asia_jp.rs index 8621bca..9b939cb 100644 --- a/riven/tests/tests_asia_jp.rs +++ b/riven/tests/tests_asia_jp.rs @@ -11,29 +11,7 @@ use riven::consts::*; const ROUTE: PlatformRoute = PlatformRoute::JP1; -// Archived 2023-08-17 -// // `teamPosition` empty: -// // AFK: -// "JP1_312062554", -// "JP1_289504387", -// "JP1_285434511", -// "JP1_307559381", -// "JP1_292569767", -// "JP1_300507433", -// "JP1_283568774", -// "JP1_310138781", -// // `individualPosition` is set but `teamPosition` is empty due to AFK slightly after beginning: -// "JP1_285797147", -// // Illegal big `championId`s. https://github.com/RiotGames/developer-relations/issues/553 -// "JP1_267647303", -// "JP1_273343663", -// // `teamPosition` empty: -// // AFK: -// "JP1_326464722", - static MATCHES: &[&str] = &[ - // Regular game: - "KR_5495121707", // Only has participant IDs for blue team. "JP1_391732436", // New field `ParticipantChallenges` `twoWardsOneSweeperCount` diff --git a/test.bash b/test.bash index 38e8094..15c8317 100755 --- a/test.bash +++ b/test.bash @@ -1,4 +1,4 @@ #!/bin/bash set -euxo pipefail -RGAPI_KEY="$(cat apikey.txt)" RUST_BACKTRACE=1 RUST_LOG=riven=debug cargo test --features nightly,deny-unknown -- --nocapture +RGAPI_KEY="$(cat apikey.txt)" RUST_BACKTRACE=1 RUST_LOG=riven=debug cargo test --no-fail-fast --features nightly,deny-unknown -- --nocapture