From 09189ab63e86740324698b867be3e4cad019191d Mon Sep 17 00:00:00 2001 From: Ethan Brierley Date: Wed, 10 Apr 2024 08:37:43 +0100 Subject: [PATCH] fix: test compilation --- reqwest-tracing/src/reqwest_otel_span_builder.rs | 9 ++++++++- reqwest-tracing/src/reqwest_otel_span_macro.rs | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/reqwest-tracing/src/reqwest_otel_span_builder.rs b/reqwest-tracing/src/reqwest_otel_span_builder.rs index a24c784..ef2395e 100644 --- a/reqwest-tracing/src/reqwest_otel_span_builder.rs +++ b/reqwest-tracing/src/reqwest_otel_span_builder.rs @@ -2,7 +2,7 @@ use std::borrow::Cow; use http::Extensions; use matchit::Router; -use reqwest::{header::HeaderValue, Request, Response, StatusCode as RequestStatusCode, Url}; +use reqwest::{Request, Response, StatusCode as RequestStatusCode, Url}; use reqwest_middleware::{Error, Result}; use tracing::{warn, Span}; @@ -344,6 +344,13 @@ fn remove_credentials(url: &Url) -> Cow<'_, str> { mod tests { use super::*; + use reqwest::header::{HeaderMap, HeaderValue}; + + fn get_header_value(key: &str, headers: &HeaderMap) -> String { + let header_default = &HeaderValue::from_static(""); + format!("{:?}", headers.get(key).unwrap_or(header_default)).replace('"', "") + } + #[test] fn get_header_value_for_span_attribute() { let expect = "IMPORTANT_HEADER"; diff --git a/reqwest-tracing/src/reqwest_otel_span_macro.rs b/reqwest-tracing/src/reqwest_otel_span_macro.rs index a757fc4..c6543e3 100644 --- a/reqwest-tracing/src/reqwest_otel_span_macro.rs +++ b/reqwest-tracing/src/reqwest_otel_span_macro.rs @@ -125,7 +125,7 @@ macro_rules! reqwest_otel_span { let host = url.host_str().unwrap_or(""); let host_port = url.port_or_known_default().unwrap_or(0) as i64; let otel_name = $name.to_string(); - let header_default = &HeaderValue::from_static(""); + let header_default = &::http::HeaderValue::from_static(""); let user_agent = format!("{:?}", $request.headers().get("user_agent").unwrap_or(header_default)).replace('"', ""); macro_rules! request_span {