From 3ddfded9e35e4f0e98edb44defdb3e13c97651fa Mon Sep 17 00:00:00 2001 From: Tom Finlayson Date: Thu, 22 Aug 2024 15:55:22 +0100 Subject: [PATCH] fix: restore adding http.url as an attribute when deprecated_attributes feature is enabled --- reqwest-tracing/src/reqwest_otel_span_builder.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/reqwest-tracing/src/reqwest_otel_span_builder.rs b/reqwest-tracing/src/reqwest_otel_span_builder.rs index 7848389..ae92e04 100644 --- a/reqwest-tracing/src/reqwest_otel_span_builder.rs +++ b/reqwest-tracing/src/reqwest_otel_span_builder.rs @@ -165,7 +165,13 @@ pub struct SpanBackendWithUrl; impl ReqwestOtelSpanBackend for SpanBackendWithUrl { fn on_request_start(req: &Request, ext: &mut Extensions) -> Span { let name = default_span_name(req, ext); - reqwest_otel_span!(name = name, req, url.full = %remove_credentials(req.url())) + let url = remove_credentials(req.url()); + let span = reqwest_otel_span!(name = name, req, url.full = %url); + #[cfg(feature = "deprecated_attributes")] + { + span.record(HTTP_URL, url.to_string()); + } + span } fn on_request_end(span: &Span, outcome: &Result, _: &mut Extensions) {